[
https://issues.apache.org/jira/browse/IMPALA-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738081#comment-16738081
]
Zoltán Borók-Nagy commented on IMPALA-7992:
-------------------------------------------
I'm a bit confused now. So the fuzz tests do generate a different set of random
values for each execution. We cover different invocations of width_bucket()
each time we execute the test.
Therefore we have more and more coverage over time. (Until we change the
implementation of e.g. width_bucket(), then we just loose all the coverage
gained so far, and start to get coverage for new random values over time).
Reducing the number of iterations means we need to execute the tests more times
to get the same amount of coverage. It should be fine because these tests are
being run all the time by gerrit, or locally by developers.
On the other hand, if the random generator was seeded with the same constant
value every time it'd mean we use the same set of random values for every test
execution. That'd mean that we indeed loose coverage by reducing the number of
iterations. But it is not the case because the tests never worked like that.
Am I missing something?
> test_decimal_fuzz.py/test_decimal_ops failing in exhaustive runs
> ----------------------------------------------------------------
>
> Key: IMPALA-7992
> URL: https://issues.apache.org/jira/browse/IMPALA-7992
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 3.2.0
> Reporter: bharath v
> Assignee: Csaba Ringhofer
> Priority: Blocker
> Labels: broken-build
>
> Error Message
> {noformat}
> query_test/test_decimal_fuzz.py:251: in test_decimal_ops
> self.execute_one_decimal_op() query_test/test_decimal_fuzz.py:247: in
> execute_one_decimal_op assert self.result_equals(expected_result, result) E
> assert <bound method TestDecimalFuzz.result_equals of
> <test_decimal_fuzz.TestDecimalFuzz object at 0xbc23cd0>>(Decimal('-0.80'),
> None) E + where <bound method TestDecimalFuzz.result_equals of
> <test_decimal_fuzz.TestDecimalFuzz object at 0xbc23cd0>> =
> <test_decimal_fuzz.TestDecimalFuzz object at 0xbc23cd0>.result_equals
> {noformat}
> Stacktrace
> {noformat}
> query_test/test_decimal_fuzz.py:251: in test_decimal_ops
> self.execute_one_decimal_op() query_test/test_decimal_fuzz.py:247: in
> execute_one_decimal_op assert self.result_equals(expected_result, result) E
> assert <bound method TestDecimalFuzz.result_equals of
> <test_decimal_fuzz.TestDecimalFuzz object at 0xbc23cd0>>(Decimal('-0.80'),
> None) E + where <bound method TestDecimalFuzz.result_equals of
> <test_decimal_fuzz.TestDecimalFuzz object at 0xbc23cd0>> =
> <test_decimal_fuzz.TestDecimalFuzz object at 0xbc23cd0>.result_equals
> {noformat}
> stderr
> {noformat}
> -- 2018-12-16 00:10:48,905 INFO MainThread: Started query
> aa4b44ad5b34c3fb:24d1838500000000
> SET decimal_v2=true;
> -- executing against localhost:21000
> select cast(-879550566.24 as decimal(11,2)) %
> cast(-10000000000000000000000.000 as decimal(28,5));
> -- 2018-12-16 00:10:48,979 INFO MainThread: Started query
> b24acf22b1607dc6:4f28753000000000
> SET decimal_v2=true;
> -- executing against localhost:21000
> select cast(17179869.184 as decimal(19,7)) /
> cast(-87808593158000679814.7939232649738916 as decimal(38,17));
> -- 2018-12-16 00:10:49,054 INFO MainThread: Started query
> 38435f02022e590a:18f7e9700000000
> SET decimal_v2=true;
> -- executing against localhost:21000
> select cast(9999999999999999999999 as decimal(32,2)) -
> cast(-519203.671959101313 as decimal(18,12));
> -- 2018-12-16 00:10:49,132 INFO MainThread: Started query
> 504edbac7ecb32ce:bfbbbe9300000000
> ~~~~~~~~~~~~~~~~~~~~~ Stack of <unknown> (140061483271936)
> ~~~~~~~~~~~~~~~~~~~~~
> File
> "/data/jenkins/workspace/impala-asf-master-exhaustive-centos6/repos/Impala/infra/python/env/lib/python2.6/site-packages/execnet/gateway_base.py",
> line 277, in _perform_spawn
> reply.run()
> File
> "/data/jenkins/workspace/impala-asf-master-exhaustive-centos6/repos/Impala/infra/python/env/lib/python2.6/site-packages/execnet/gateway_base.py",
> line 213, in run
> self._result = func(*args, **kwargs)
> File
> "/data/jenkins/workspace/impala-asf-master-exhaustive-centos6/repos/Impala/infra/python/env/lib/python2.6/site-packages/execnet/gateway_base.py",
> line 954, in _thread_receiver
> msg = Message.from_io(io)
> File
> "/data/jenkins/workspace/impala-asf-master-exhaustive-centos6/repos/Impala/infra/python/env/lib/python2.6/site-packages/execnet/gateway_base.py",
> line 418, in from_io
> header = io.read(9) # type 1, channel 4, payload 4
> File
> "/data/jenkins/workspace/impala-asf-master-exhaustive-centos6/repos/Impala/infra/python/env/lib/python2.6/site-packages/execnet/gateway_base.py",
> line 386, in read
> data = self._read(numbytes-len(buf))
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
