[
https://issues.apache.org/jira/browse/IMPALA-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750194#comment-16750194
]
ASF subversion and git services commented on IMPALA-3323:
---------------------------------------------------------
Commit 561158b30656b97ccb6ec83052b62c476e0873ed in impala's branch
refs/heads/master from Fredy Wijaya
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=561158b ]
IMPALA-3323: Fix unrecognizable shell option when --config_file is specified
Impala shell defines a dictionary of default values for some shell
options. Before this patch, the logic for --config_file checks if
a shell option exists by using the default value dictionary, which
does not contain the exhaustive list of shell options. This causes
a valid option in the Impala shell config file to be treated as
unrecognizable shell option due to the option not having a default
value. The patch fixes the issue by changing the logic that checks
for the existence of an option using the option list from optparse.
The patch also fixes the missing dest parameter for ldap_password_cmd
option.
Testing:
- Updated test_shell_commandline::test_config_file
- Ran all shell tests
Change-Id: Iff371d038fa77ba659e9b7c7a4ed5b374237f2ea
Reviewed-on: http://gerrit.cloudera.org:8080/12245
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> impala-shell --ldap_password_cmd has no config file equivalent
> --------------------------------------------------------------
>
> Key: IMPALA-3323
> URL: https://issues.apache.org/jira/browse/IMPALA-3323
> Project: IMPALA
> Issue Type: Bug
> Components: Clients
> Affects Versions: Impala 2.5.0
> Reporter: John Russell
> Assignee: Fredy Wijaya
> Priority: Minor
> Labels: newbie
> Fix For: Impala 3.2.0
>
>
> Putting ldap_password_cmd in the .impalarc file results in a parse error when
> impala-shell starts up. Judging from the impala-shell source, it looks like a
> dest= parameter is missing so there's no config file equivalent for the
> --ldap_password_cmd command-line option. E.g. here's one with a config file
> equivalent and one without:
> {code}
> parser.add_option("--auth_creds_ok_in_clear", dest="creds_ok_in_clear",
> action="store_true", help="If set, LDAP authentication " +
> "may be used with an insecure connection to Impala. " +
> "WARNING: Authentication credentials will therefore be
> sent " +
> "unencrypted, and may be vulnerable to attack.")
> parser.add_option("--ldap_password_cmd",
> help="Shell command to run to retrieve the LDAP password")
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
