Paul Rogers created IMPALA-8157: ----------------------------------- Summary: Log exceptions from the FrontEnd Key: IMPALA-8157 URL: https://issues.apache.org/jira/browse/IMPALA-8157 Project: IMPALA Issue Type: Improvement Components: Frontend Affects Versions: Impala 3.1.0 Reporter: Paul Rogers Assignee: Fang-Yu Rao
The BE calls into the FE for a variety of operations. Each of these may fail in expected ways (invalid query, say) or unexpected ways (a code change introduces a null pointer exception.) At present, the BE logs only the exception, and only at the INFO level. This ticket asks to log all unexpected exceptions at the ERROR level. The basic idea is to extend all FE entry points to do: {code:java} try { // Do the operation } catch (ExpectedException e) { // Don't log expected exceptions throw e; } catch (Throwable e) { LOG.error("Something went wrong", e); throw e; } {code} The above code logs all exceptions except for those that are considered expected. The job of this ticket is to: * Find all the entry points * Identify which, if any, exceptions are expected * Add logging code with an error message that identifies the operation This pattern was tested ad-hoc to find a bug during development and seems to work fine. As. a result, the change is mostly a matter of the above three steps. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org