[
https://issues.apache.org/jira/browse/IMPALA-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Armstrong updated IMPALA-8147:
----------------------------------
Description:
make_impala.sh seems to be an unnecessary layer in the build system between
buildall.sh and the CMake scripts. Per discussion on dev@, I think we should:
* Move any logic required for doing incremental builds into CMakeLists. E.g.
gen_build_version.py
* *maybe* consider moving the CMake invocation logic into a separate script
that does one clear-cut thing
* Move the make invocation logic into a function in buildall.sh
* Add support to buildall.sh to build both the debug and release binaries.
was:
make_impala.sh seems to be an unnecessary layer in the build system between
buildall.sh and the CMake scripts. Per discussion on dev@, I think we should:
* Move any logic required for doing incremental builds into CMakeLists. E.g.
gen_build_version.py
* *maybe* consider moving the CMake invocation logic into a separate script
that does one clear-cut thing
* Move the make invocation logic into a function in buildall.sh
> Merge make_impala.sh into CMake and buildall.sh
> -----------------------------------------------
>
> Key: IMPALA-8147
> URL: https://issues.apache.org/jira/browse/IMPALA-8147
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
>
> make_impala.sh seems to be an unnecessary layer in the build system between
> buildall.sh and the CMake scripts. Per discussion on dev@, I think we should:
> * Move any logic required for doing incremental builds into CMakeLists. E.g.
> gen_build_version.py
> * *maybe* consider moving the CMake invocation logic into a separate script
> that does one clear-cut thing
> * Move the make invocation logic into a function in buildall.sh
> * Add support to buildall.sh to build both the debug and release binaries.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
