[
https://issues.apache.org/jira/browse/IMPALA-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760890#comment-16760890
]
ASF subversion and git services commented on IMPALA-8093:
---------------------------------------------------------
Commit b7bd6ac44dfbc5f82e5cba52bf7e751f62a35751 in impala's branch
refs/heads/master from Yongzhi Chen
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b7bd6ac ]
IMPALA-8093: Prefix time series counters with a hyphen
The change makes profiles prefix counters consistent.
Only TimeSeriesCounters are affected.
Testing:
Add TimeSeriesCounter prefix checks in test_observability tests.
Manual Tests: Run query and check profile for MemoryUsage and
ThreadUsage. Following section of profile shows that TimeSeriesCounters
are consistent with other counters:
Fragment F00:
. . .
Fragment Instance Lifecycle Event Timeline: 273.841ms
- Prepare Finished: 1.511ms (1.511ms)
. . .
- MemoryUsage(500.000ms): 2.81 MB
- ThreadUsage(500.000ms): 1
- AverageThreadTokens: 1.00
- BloomFilterBytes: 1.00 MB (1048576)
- ExchangeScanRatio: 0.00
- PeakMemoryUsage: 54.26 MB (56891933)
- PeakReservation: 53.00 MB (55574528)
Change-Id: I2e3f08da765b3e6dedead45760729cbc5e8fb6fa
Reviewed-on: http://gerrit.cloudera.org:8080/12296
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Profiles prefix counters inconsistently
> ---------------------------------------
>
> Key: IMPALA-8093
> URL: https://issues.apache.org/jira/browse/IMPALA-8093
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 3.2.0
> Reporter: Lars Volker
> Assignee: Yongzhi Chen
> Priority: Major
> Labels: newbie, observability, profile, ramp-up
>
> In pretty printed profiles, plain counters are prefixed with \{{ - }} but
> TimeSeriesCounters are not. We should make them consistent.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
