[
https://issues.apache.org/jira/browse/IMPALA-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761491#comment-16761491
]
ASF subversion and git services commented on IMPALA-5821:
---------------------------------------------------------
Commit 14996f495129eaee35ee030be87b289b9dae517e in impala's branch
refs/heads/master from Andrew Sherman
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=14996f4 ]
IMPALA-8103: In Analyzed Query use /* and */ to delimit hints.
IMPALA-5821 added the analyzed query text to the output of EXPLAIN when
explain_level is 2 or greater. Any query hits were displayed in the form
SELECT
-- +straight_join
* FROM table_name [...]
which meant that care had to be taken to embed and preserve newlines in
the EXPLAIN output. This change makes the output to be of the form
SELECT /* +straight_join */ * FROM table_name [...]
The /* +straight_join */ form was chosen over /*+straight_join */ as
it seems more readable, and is more commonly used in exiting tests.
To do this the following changes were made:
ToSqlUtils.getPlanHintsSql() was extended to take a ToSqlOptions
parameter. If this parameter indicates that the analyzed query is being
shown, then the hints are surrounded with '/*' and '*/'.
PrintUtils.wrapString() was simplified as it no longer has to preserve
newlines in a an analyzed query.
TESTING
All end-to-end tests were run.
The output in a few .test files was updated.
A couple of new cases were added to ToSqlTest.java
Change-Id: I7215a4c17508e3408680a1d2bb6c3af355c78c8d
Reviewed-on: http://gerrit.cloudera.org:8080/12360
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Distinguish numeric types and show implicit cast in EXTENDED explain plans
> --------------------------------------------------------------------------
>
> Key: IMPALA-5821
> URL: https://issues.apache.org/jira/browse/IMPALA-5821
> Project: IMPALA
> Issue Type: Improvement
> Components: Frontend
> Affects Versions: Impala 2.8.0
> Reporter: Matthew Jacobs
> Assignee: Andrew Sherman
> Priority: Minor
> Labels: supportability, usability
> Fix For: Impala 3.1.0
>
>
> In this plan, it wasn't clear that the constant in the predicate was being
> evaluated to a double. Then the lhs required an implicit cast, and the
> predicate couldn't be pushed to Kudu:
> {code}
> [localhost:21000] > explain select * from functional_kudu.alltypestiny where
> bigint_col < 1000 / 100;
> Query: explain select * from functional_kudu.alltypestiny where bigint_col <
> 1000 / 100
> +---------------------------------------------+
> | Explain String |
> +---------------------------------------------+
> | Per-Host Resource Reservation: Memory=0B |
> | Per-Host Resource Estimates: Memory=10.00MB |
> | Codegen disabled by planner |
> | |
> | PLAN-ROOT SINK |
> | | |
> | 00:SCAN KUDU [functional_kudu.alltypestiny] |
> | predicates: bigint_col < 10 |
> +---------------------------------------------+
> {code}
> We should make it more clear by printing it in a way that makes it clear that
> it's being interpreted as a DOUBLE, e.g. by wrapping in a cast.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
