[
https://issues.apache.org/jira/browse/IMPALA-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763583#comment-16763583
]
ASF subversion and git services commented on IMPALA-8147:
---------------------------------------------------------
Commit d0c103095019f1b80dec63193847eb516d7f8dd7 in impala's branch
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d0c1030 ]
IMPALA-8147: part 1/2: make make_*.sh redundant.
The logic in that file, which is mostly about constructing argument
lists for CMake and make, is moved to functions in buildall.sh.
A new option -release_and_debug is added to buildall.sh to build
both the debug and release builds. This is convenient for building
a binary Impala for distribution because you want to have both
sets of binaries available.
make*.sh are not yet removed in order to make the transition easier.
Testing:
Ran buildall.sh locally with -release_and_debug, confirmed that
all of the right binaries were generated.
Change-Id: I70e4f65712166348ca006bc68e1a1e18e853d3a0
Reviewed-on: http://gerrit.cloudera.org:8080/12368
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Merge make_impala.sh into CMake and buildall.sh
> -----------------------------------------------
>
> Key: IMPALA-8147
> URL: https://issues.apache.org/jira/browse/IMPALA-8147
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
>
> make_impala.sh seems to be an unnecessary layer in the build system between
> buildall.sh and the CMake scripts. Per discussion on dev@, I think we should:
> * Move any logic required for doing incremental builds into CMakeLists. E.g.
> gen_build_version.py
> * *maybe* consider moving the CMake invocation logic into a separate script
> that does one clear-cut thing
> * Move the make invocation logic into a function in buildall.sh
> * Add support to buildall.sh to build both the debug and release binaries.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
