[
https://issues.apache.org/jira/browse/IMPALA-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765659#comment-16765659
]
ASF subversion and git services commented on IMPALA-7694:
---------------------------------------------------------
Commit 8b5cb576d23d771456ed571ee0d362d96af6ae13 in impala's branch
refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=8b5cb57 ]
IMPALA-8173: Fix KeyError in run-workload.py
A recent change (IMPALA-7694) causes run-workload.py to fail with a
KeyError due to trying to construct an ImpalaBeeswaxResult without a
query id.
This patch fixes that issue and two related issues:
- This problem was not caught by automated testing even though we run
run-workload.py in run-all-tests.sh because of an issue where
queries that fail to produce results are silently ignored.
- Fixes an issue where queries that fail to produce results would
confusingly produce the error:
'NoneType' object has no attribute 'time_taken'
Testing:
- Ran run-workload.py locally and demonstrated that it works now.
- Ran run-all-tests.sh locally and demonstrated that it fails now when
the KeyError issue isn't fixed.
Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Reviewed-on: http://gerrit.cloudera.org:8080/12397
Reviewed-by: Thomas Marshall <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Add CPU resource utilization (user, system, iowait) timelines to profiles
> -------------------------------------------------------------------------
>
> Key: IMPALA-7694
> URL: https://issues.apache.org/jira/browse/IMPALA-7694
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 3.1.0
> Reporter: Lars Volker
> Assignee: Lars Volker
> Priority: Major
> Labels: observability, supportability
> Fix For: Impala 3.2.0
>
>
> We often struggle to determine why a query was slow, in particular if it was
> caused by other tasks on the same machine using resources. To help with this
> we should include timelines for system resource utilization to the profiles.
> These should eventually include CPU and disk and network I/O. If it is too
> expensive to include these in all queries we should add a flag to add these
> to a percentage of queries, and a query option to force-enable them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
