[ 
https://issues.apache.org/jira/browse/IMPALA-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767692#comment-16767692
 ] 

ASF subversion and git services commented on IMPALA-8187:
---------------------------------------------------------

Commit 55b9c899b1c1f5d0e6d7fde5eff677bb015c2e54 in impala's branch 
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=55b9c89 ]

IMPALA-8187: UDF samples hide symbols by default

Testing:
Ran UDF tests, confirmed that changing the compile flags without adding
IMPALA_UDF_EXPORT caused them to fail because they couldn't find
the symbols.

Added a test to check that symbols are actually hidden.

Change-Id: Ie17b74b9bce9cc6962393017879b65409ce23b28
Reviewed-on: http://gerrit.cloudera.org:8080/12451
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> UDF/UDA samples should explicitly export entry points
> -----------------------------------------------------
>
>                 Key: IMPALA-8187
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8187
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>
> It's possible for UDF authors to get into a pickle by exporting symbols from 
> UDF/UDA shared objects unintentionally. E.g. if using boost headers, which 
> result in weak symbols in the .so, which then get merged with the 
> (incompatible) symbols in the impalad binary.
> We should really be keeping symbols hidden by default then exporting the 
> entry points explicitly in the UDF/UDA code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to