[ 
https://issues.apache.org/jira/browse/IMPALA-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771582#comment-16771582
 ] 

ASF subversion and git services commented on IMPALA-8193:
---------------------------------------------------------

Commit 4344914bb3da582d4ed7d73d08c8a274033b5430 in impala's branch 
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=4344914 ]

IMPALA-8193: Fix python 2.6 issue in junit_prune_notrun.py

Python 2.6's ElementTree.write() does not have an xml_declaration
argument, so junitxml_prune_notrun.py fails on python 2.6.

This fixes junitxml_prune_notrun.py by using minidom to write
the output. This mirrors how bin/generate_junitxml.py outputs
XML.

Verified that tests now pass on python 2.6 and python 2.7 does
not change.

Change-Id: I9ef8fb77b1ac8c51e3dfb6b04690ae9ccc490d62
Reviewed-on: http://gerrit.cloudera.org:8080/12479
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> junitxml_prune_notrun.py fails on Centos6 passing xml_declaration=True to 
> ElementTree 
> --------------------------------------------------------------------------------------
>
>                 Key: IMPALA-8193
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8193
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 3.2.0
>            Reporter: Andrew Sherman
>            Assignee: Joe McDonnell
>            Priority: Blocker
>              Labels: broken-build
>
> I assume this fails because the version of python on Centos6 is old.
> {quote}
> [==========] Running 5 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 5 tests from Bitmap
> [ RUN      ] Bitmap.SetupTest
> [       OK ] Bitmap.SetupTest (0 ms)
> [ RUN      ] Bitmap.SetAllTest
> [       OK ] Bitmap.SetAllTest (0 ms)
> [ RUN      ] Bitmap.SetGetTest
> [       OK ] Bitmap.SetGetTest (1 ms)
> [ RUN      ] Bitmap.OverflowTest
> [       OK ] Bitmap.OverflowTest (0 ms)
> [ RUN      ] Bitmap.MemUsage
> [       OK ] Bitmap.MemUsage (0 ms)
> [----------] 5 tests from Bitmap (1 ms total)
> [----------] Global test environment tear-down
> [==========] 5 tests from 1 test case ran. (1 ms total)
> [  PASSED  ] 5 tests.
>   YOU HAVE 1 DISABLED TEST
> 19/02/11 15:53:03 INFO util.JvmPauseMonitor: Starting JVM pause monitor
> Traceback (most recent call last):
>   File 
> "/data/jenkins/workspace/impala-cdh6.x-exhaustive-centos6/repos/Impala/bin/junitxml_prune_notrun.py",
>  line 65, in <module>
>     if __name__ == "__main__": main()
>   File 
> "/data/jenkins/workspace/impala-cdh6.x-exhaustive-centos6/repos/Impala/bin/junitxml_prune_notrun.py",
>  line 62, in main
>     junitxml_prune_notrun(options.filename)
>   File 
> "/data/jenkins/workspace/impala-cdh6.x-exhaustive-centos6/repos/Impala/bin/junitxml_prune_notrun.py",
>  line 55, in junitxml_prune_notrun
>     tree.write(junitxml_filename, encoding="utf-8", xml_declaration=True)
> TypeError: write() got an unexpected keyword argument 'xml_declaration'
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to