[ 
https://issues.apache.org/jira/browse/IMPALA-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773600#comment-16773600
 ] 

Lars Volker commented on IMPALA-8236:
-------------------------------------

Doesn't this also apply to old readers for other structs that require a TUnit, 
e.g. TSummaryStatsCounter or TTimeSeriesCounter?

> Adding new TUnit values to runtime profile is broken
> ----------------------------------------------------
>
>                 Key: IMPALA-8236
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8236
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 2.12.0, Impala 3.1.0
>            Reporter: Tim Armstrong
>            Priority: Major
>              Labels: observability
>
> See IMPALA-8235 for context.
> The problem this tracks is that there's no way to add a new value to the 
> TUnit enum, which is required in TCounter, without breaking existing readers 
> (at least Java readers), which will fail to decode TCounter values with an 
> enum value they don't recognise.
> The workaround is to only use  the following units in anything that is 
> serialised into a TCounter:
> {noformat}
>   UNIT,
>   UNIT_PER_SECOND,
>   CPU_TICKS,
>   BYTES
>   BYTES_PER_SECOND,
>   TIME_NS,
>   DOUBLE_VALUE
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to