[
https://issues.apache.org/jira/browse/IMPALA-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774439#comment-16774439
]
ASF subversion and git services commented on IMPALA-8235:
---------------------------------------------------------
Commit c8634b5287ad1a03461c340845f14053aab38230 in impala's branch
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=c8634b5 ]
IMPALA-8235: avoid TIME_MS in runtime profile
There are issues with using new TUnit values in runtime profiles that
are consumed by readers with an older version of the thrift
definitions.
Work around the issue by using the older TIME_NS type for this
counter.
Testing:
Confirmed manually that a tool with an old version of the thrift API
(Cloudera Manager) could parse the profile.
Change-Id: Ia6a0846f401ced1947187b8581563de9dbb4fe53
Reviewed-on: http://gerrit.cloudera.org:8080/12544
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> AdmissionControlTimeSinceLastUpdate TIME_MS counter breaks some profile
> consumers
> ---------------------------------------------------------------------------------
>
> Key: IMPALA-8235
> URL: https://issues.apache.org/jira/browse/IMPALA-8235
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 3.2.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Blocker
> Labels: observability
>
> The issue is:
> * type is a required field for TCounter with enum type TUnit
> * Some readers (e.g. Java) that encounter an unknown enum value replace it it
> with null, then throw an exception because it is a required field
> This means that the workflow for adding a new TUnit is basically broken,
> since we can't add a unit in Impala then update readers later.
> I think we should switch to TIME_NS then reconsider the workflow here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
