[
https://issues.apache.org/jira/browse/IMPALA-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775401#comment-16775401
]
ASF subversion and git services commented on IMPALA-8234:
---------------------------------------------------------
Commit 91d8a8f6280b2b802fe8ccc52251937c5a415766 in impala's branch
refs/heads/master from Lars Volker
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=91d8a8f ]
IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning
IMPALA-7694 added a field in the middle of the Metrics.TUnit enum, which
broke backwards compatibility with profiles that had been written by
older versions of Impala. This change fixes the ordering by moving the
field to the end of the enum.
Additionally, it adds a warning to the top of all Thrift files that are
part of the binary profile format, and an note of caution to the main
definition in RuntimeProfile.thrift.
This change also fixes the order of all enums in our Thrift files to
make errors like this less likely in the future.
Change-Id: If215f16a636008757ceb439edbd6900a1be88c59
Reviewed-on: http://gerrit.cloudera.org:8080/12543
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> TUnit enum (part of profile format) was reordered
> -------------------------------------------------
>
> Key: IMPALA-8234
> URL: https://issues.apache.org/jira/browse/IMPALA-8234
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Tim Armstrong
> Assignee: Lars Volker
> Priority: Blocker
> Labels: observability
>
> IMPALA-7694 inserted BASIS_POINTS into TUnit, which will change the assigned
> enum values of subsequent units. I think those are fairly rarely used, but it
> would be good to fix this before the release to avoid any disruption.
> Maybe it's a good idea to explicitly number the enum elements to make it
> clear what the wire format is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
