[
https://issues.apache.org/jira/browse/IMPALA-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776606#comment-16776606
]
ASF subversion and git services commented on IMPALA-7215:
---------------------------------------------------------
Commit f823c46099aef28fe01c7348f8bd94c11b7fb7d3 in impala's branch
refs/heads/2.x from Sailesh Mukil
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f823c46 ]
IMPALA-7215: Implement a templatized CountingBarrier
Currently, our CountingBarrier util only notifies a 'bool' value
and uses an underlying Promise<bool>.
We're seeing cases in code where we might want to be notified of a
different kind of Promise (other than bool). We add a templatized
class TypedCountingBarrier<T> and convert CountingBarrier to use the
TypedCountingBarrier<T> internally.
This was identified while working on IMPALA-7163.
Testing: Ran 'core' tests.
Change-Id: I05fc79228250408ae16481ae7ff3491a90d26b8e
Reviewed-on: http://gerrit.cloudera.org:8080/10827
Reviewed-by: Sailesh Mukil <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Implement a templatized CountingBarrier
> ---------------------------------------
>
> Key: IMPALA-7215
> URL: https://issues.apache.org/jira/browse/IMPALA-7215
> Project: IMPALA
> Issue Type: Improvement
> Affects Versions: Impala 3.0
> Reporter: Sailesh Mukil
> Assignee: Sailesh Mukil
> Priority: Major
> Fix For: Impala 2.13.0, Impala 3.1.0
>
>
> Currently, our CountingBarrier util only notifies a 'bool' value and uses an
> underlying Promise<bool>.
> We're seeing cases in code where we might want to be notified of a different
> kind of Promise (other than bool). We can convert this utility code to be
> templatized to be able to reuse the CountingBarrier for these new use cases
> as well.
> This was identified while working on IMPALA-7163.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
