[
https://issues.apache.org/jira/browse/IMPALA-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778242#comment-16778242
]
ASF subversion and git services commented on IMPALA-8247:
---------------------------------------------------------
Commit e9936b02cf5b9673d6dd8f3624b07e2ec81f763e in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e9936b0 ]
IMPALA-8247: Fix tests missing from unified backend executable
When converting the tests in be/src/util to the unified backend
test executable in IMPALA-8071, some tests did not get linked
into the executable appropriately. This means that they stopped
running. Specifically, the tests in bit-stream-utils-test.cc
and system-state-info-test.cc were left out.
This adds them back and modifies bin/validate-unified-backend-filters.py
to check both directions:
- If a filter is specified, it must match a test in the executable.
- If the executable has a test, some filter must match it.
I ran the backend tests on debug and ASAN with this change.
Change-Id: I80d8b5779cb0ac663e32c72722e0c73b68a43d2e
Reviewed-on: http://gerrit.cloudera.org:8080/12584
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Tim Armstrong <[email protected]>
> Backend tests from bit-stream-utils-test.cc and system-state-info-test.cc are
> not running
> -----------------------------------------------------------------------------------------
>
> Key: IMPALA-8247
> URL: https://issues.apache.org/jira/browse/IMPALA-8247
> Project: IMPALA
> Issue Type: Bug
> Components: Backend, Infrastructure
> Affects Versions: Impala 3.2.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Blocker
> Labels: broken-build
>
> Several tests in be/src/util were converted to the unified backend test
> executable in IMPALA-8071. Unfortunately, some tests stopped running as part
> of this change. Specifically, the tests in bit-stream-utils-test.cc and
> system-state-info-test.cc were not included in the test binary and stopped
> running. The tests changed to use ADD_UNIFIED_BE_LSAN_TEST, but the files
> were not included in the UtilTests library.
> These two files should be included in the test executable and we need to
> update the validation of the unified test executable
> (bin/validate-unified-backend-test-filters.py) to catch this case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
