[
https://issues.apache.org/jira/browse/IMPALA-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779110#comment-16779110
]
ASF subversion and git services commented on IMPALA-4784:
---------------------------------------------------------
Commit a85187b556ef43f3bc8b95262aa5854f98b7e9ee in impala's branch
refs/heads/2.x from Sailesh Mukil
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a85187b ]
IMPALA-4784: Remove InProcessStatestore
InProcessStatestore was only used by statestore-test, expr-test and
session-expiry-test. With a slight refactor of the Statestore class,
InProcessStatestore becomes obsolete.
This patch moves the ownership of the ThriftServer into the Statestore
class and Statestore::Init() now takes a 'port' parameter instead of
using the FLAGS_state_store_port directly.
We also remove the InProcessStatestore completely. A follow on patch will
get rid of the InProcessImpalaServer too (IMPALA-6013)
Testing: Ran 'core' tests.
Change-Id: I2621873e593b36c9612a6402ac6c5d8e3b49cde9
Reviewed-on: http://gerrit.cloudera.org:8080/10843
Reviewed-by: Sailesh Mukil <sail...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/12581
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Remove InProcessStatestore
> --------------------------
>
> Key: IMPALA-4784
> URL: https://issues.apache.org/jira/browse/IMPALA-4784
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend, Distributed Exec
> Affects Versions: Impala 2.9.0
> Reporter: Henry Robinson
> Assignee: Sailesh Mukil
> Priority: Major
> Fix For: Impala 2.13.0, Impala 3.1.0
>
>
> The {{InProcessStatestore}} class is only used by the {{statestore-test}} and
> is likely to be obsoleted by the KRPC work. Since {{statestore-test}} doesn't
> provide much test coverage at all, let's remove {{InProcessStatestore}} to
> avoid the need to keep it up-to-date.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
