[ 
https://issues.apache.org/jira/browse/IMPALA-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786004#comment-16786004
 ] 

ASF subversion and git services commented on IMPALA-8250:
---------------------------------------------------------

Commit 8b2e2a6a18be3dc8d5f591a2e9193f02bb64af68 in impala's branch 
refs/heads/master from Philip Zeyliger
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=8b2e2a6 ]

Simplify JNI exception-handling macros.

This simplifies the implementations of ABORT_IF_EXC() and
CLEAN_EXIT_IF_EXC() by reducing them to usages
of JniUtil::GetJniExceptionMsg() and our typical Status-handling
macros. The existing implementations didn't clear
the exception before calling additional Java methods,
whereas JniUtil::GetJniExceptionMsg() already handled
that correctly.

I tested this manually by renaming a class in catalogd's startup
sequence to a class that doesn't exist and checked that the crash
logging was useful, containing both the Java and C++ stack traces
with both macros.

This is part of IMPALA-8250.

Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c
Reviewed-on: http://gerrit.cloudera.org:8080/12659
Reviewed-by: Philip Zeyliger <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Impala crashes with -Xcheck:jni
> -------------------------------
>
>                 Key: IMPALA-8250
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8250
>             Project: IMPALA
>          Issue Type: Task
>            Reporter: Philip Zeyliger
>            Priority: Major
>
> The JVM has a checker for JNI usage, and Impala (and libhdfs) have some 
> violations. This ticket captures figuring that out. At least one of the 
> issues can crash Impala.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to