[
https://issues.apache.org/jira/browse/IMPALA-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786006#comment-16786006
]
ASF subversion and git services commented on IMPALA-8273:
---------------------------------------------------------
Commit eba08aa749211522631b16f87bf0f113d2470f29 in impala's branch
refs/heads/master from Vihang Karajgaonkar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=eba08aa ]
IMPALA-8278 : Fix MetastoreEventsProcessorTest flakiness
MetastoreEventsProcessorTest#testEventProcessorFetchAfterHMSRestart
causes test flakiness because the event processor instantiated is not
stopped. This causes the test to have 2 instances of EventsProcessor
running concurrently during the test execution. Depending on the timing
of the poll operations all the events are processed twice and they
modify the state of test catalog concurrently causing race conditions
which lead to intermittent test failures.
The patch also fixes a race condition in testEventSyncFlagTurnedOnErrorCase
where the test assumes and all the tables will be available in catalog
immediately after reset() completes. This assumption is not true and
hence removed the flaky assertNull check in there.
Also, changes the MetastoreEventsProcessorTest to make it easier to
debug through logs. Each individual test case uses a different table
name so that logs pertaining to a test case can be easily grepped.
Testing done:
1. Confirmed that two event processors are running by manually adding
identifiers to each event processing and log them when they receive the
events before this patch. After patch same test does not reveal multiple
event processors running.
2. Ran the test multiple times locally to confirm that test works
everytime.
3. Applied patch for IMPALA-8273 along with this patch and ran
full-tests using jenkins job and see no failure
Change-Id: Ia12b1d048d8c8c59fa4c587bf65772ff194d314d
Reviewed-on: http://gerrit.cloudera.org:8080/12656
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Change metastore configuration template so that table parameters do not
> exclude impala specific properties
> ----------------------------------------------------------------------------------------------------------
>
> Key: IMPALA-8273
> URL: https://issues.apache.org/jira/browse/IMPALA-8273
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Priority: Major
> Fix For: Impala 3.2.0
>
>
> CDH Hive has a configuration
> {{hive.metastore.notification.parameters.exclude.patterns}} which gives the
> ability to exclude certain parameter keys from notification events. This is
> mainly used as a safety valve in case there are huge values stored in these
> parameter maps. The template file should make sure that the parameter
> exclusion is disabled (or atleast configured such that it does not exclude
> {{impala.disableHmsSync}} which is needed by this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
