[
https://issues.apache.org/jira/browse/IMPALA-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793156#comment-16793156
]
ASF subversion and git services commented on IMPALA-8271:
---------------------------------------------------------
Commit b7c1124b9e8fc17a75d45c2380379ad28e98d332 in impala's branch
refs/heads/master from Fredy Wijaya
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b7c1124 ]
IMPALA-8271: Refactor the use of Thrift enums for query options
This patch refactors the use of Thrift enums with GetThriftEnum helper
function that can automatically validate and convert the query option
value into the corresponding Thrift enum value. The validation error
message has also been improved to list all possible valid query option
values.
Testing:
- Added missing test cases in both BE and E2E
- Ran query-options-test.cc
- Ran metadata/test_set.py
- Ran query_test/test_nested_types.py
- Ran query_test/test_scanners.py
Change-Id: I6d747aae2c689765be72e117ce030ce4e3ce4641
Reviewed-on: http://gerrit.cloudera.org:8080/12682
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Refactor the use of Thrift enums in query-options.cc
> ----------------------------------------------------
>
> Key: IMPALA-8271
> URL: https://issues.apache.org/jira/browse/IMPALA-8271
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Fredy Wijaya
> Assignee: Fredy Wijaya
> Priority: Minor
> Labels: ramp-up
> Fix For: Impala 3.3.0
>
>
> Currently the logic for handling Thrift enums in query-options is very
> error-prone. A change in Thrift enums require updating query-options.cc. For
> example:
> https://github.com/apache/impala/blob/master/be/src/service/query-options.cc#L276-L288.
> This CR: https://gerrit.cloudera.org/c/12635/ is an attempt to fix such
> issue for compression_codec.
> This ticket aims to update the use of Thrift enums with the style similar to:
> https://gerrit.cloudera.org/c/12635/ to make it less error-prone.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
