[
https://issues.apache.org/jira/browse/IMPALA-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793921#comment-16793921
]
ASF subversion and git services commented on IMPALA-337:
--------------------------------------------------------
Commit 53ef115e8e5cac231ef948f8670106c348d197fe in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=53ef115 ]
IMPALA-337: Add support for POST to the webserver
In order to support the TraceEvent path handlers from Kudu (and
other functionality like pprof symbolization), the webserver needs
to support HTTP POST. This changes the signature for HTTP handler
callbacks to take a 'WebRequest' struct instead of a simple map of
arguments. This struct exposes the request type, POST data, and
unparsed query strings, enabling the callbacks to handle POSTs.
The struct itself is imported from Kudu's webserver code, so we can
start to share utility HTTP handlers (eg pprof or tracing) more
easily between Kudu and Impala.
The maximum length of a POST request is limited by the new
webserver_max_post_length_bytes parameter, which defaults to
1MB.
This patch was written by Todd Lipcon, based on code from Kudu.
Testing:
- Added a test for too big POSTs to custom_cluster/test_web_pages.py
- Verifies the existing core tests pass
Change-Id: I3bd3ecfab53263c13a4509c278569302c9901abb
Reviewed-on: http://gerrit.cloudera.org:8080/12730
Reviewed-by: Todd Lipcon <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Update Impala debug webserver to accept HTTP POST requests
> ----------------------------------------------------------
>
> Key: IMPALA-337
> URL: https://issues.apache.org/jira/browse/IMPALA-337
> Project: IMPALA
> Issue Type: Task
> Components: Distributed Exec
> Affects Versions: Impala 1.1
> Reporter: Lenni Kuff
> Priority: Minor
>
> The Impala debug webserver doesn't currently handle HTTP POST requests. It
> appears the requested handler is being called, but the request is being
> treated as a GET. It would be useful to update the webserver to accept both
> GET and POST commands.
> This is something that is required if we want to have Impala to provide
> automatic symbol resolution for remote profiling of the process.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
