[ 
https://issues.apache.org/jira/browse/IMPALA-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795216#comment-16795216
 ] 

ASF subversion and git services commented on IMPALA-8305:
---------------------------------------------------------

Commit ab9a7b7e1982a534c0cfd341836120bf6ae30cb4 in impala's branch 
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ab9a7b7 ]

IMPALA-8305: Generate JUnitXML for DCHECK failures

DCHECKs log at the FATAL level and produce a statement starting
with "Check failed:". This generates a JUnitXML when it sees a
FATAL log file with "Check failed:". Some backend death tests
specifically test hitting certain DCHECKs, so the be_tests
directory is ignored.

Something that hits a DCHECK would also generate a minidump,
so this is just additional information beyond the existing
JUnitXML for the minidump.

Testing:
 - Tested on logs from a test that hit a DCHECK in impalad
 - Ran a normal error-free run

Change-Id: Ic45d01b6a87b1d81967f1e10028af96a7cc3071a
Reviewed-on: http://gerrit.cloudera.org:8080/12751
Reviewed-by: David Knupp <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Generate JUnitXML symptom to detect crashes due to a DCHECK
> -----------------------------------------------------------
>
>                 Key: IMPALA-8305
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8305
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 3.3.0
>            Reporter: Joe McDonnell
>            Assignee: Joe McDonnell
>            Priority: Major
>
> When an impalad or other process hits a DCHECK, it outputs a FATAL log with 
> information about the check that failed. For example:
> {noformat}
> Log file created at: 2019/02/17 00:27:43
> Running on machine: 
> impala-ec2-centos74-r4-4xlarge-ondemand-0a7e.vpc.cloudera.com
> Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg
> F0217 00:27:43.730983 109290 query-state.cc:604] 
> 154c7230f098d1a5:e75d0b400000000] Check failed: is_cancelled_.Load() == 1 (0 
> vs. 1){noformat}
> Like all impalad crashes, this can show up as random tests failing. This 
> FATAL log should generate a JUnitXML symptom containing the log output.
> The check will need to navigate some exceptions. For example, some backend 
> tests intentionally hit DCHECKs (e.g. buffer-pool-test and some others). 
> Also, there is a custom cluster test that fails impalad startup and generates 
> a FATAL log that is not a DCHECK.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to