[
https://issues.apache.org/jira/browse/IMPALA-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796797#comment-16796797
]
ASF subversion and git services commented on IMPALA-8320:
---------------------------------------------------------
Commit 3baf08ae3b8bf2bcf6d83a4a8b9259d12bbdad84 in impala's branch
refs/heads/master from Lars Volker
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=3baf08a ]
IMPALA-8320: Handle psutil error in tests
We use psutil.Process.cmdline to access a process's command line. This
field is a property and tries to retrieve process information from the
OS. If the process has terminated in the meantime, such access will
result in an error which we need to handle. This change adds proper
error handling. I ran the existing Breakpad tests to make sure we don't
regress, but there's no obvious way to test that particular corner case
that would be worth the effort.
Change-Id: Ia5fec061f845d3deb6328e52e590a7a79196dfd4
Reviewed-on: http://gerrit.cloudera.org:8080/12792
Reviewed-by: Lars Volker <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> TestBreakpadExhaustive.test_minidump_cleanup_thread hits NoSuchProcess
> exception
> --------------------------------------------------------------------------------
>
> Key: IMPALA-8320
> URL: https://issues.apache.org/jira/browse/IMPALA-8320
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 3.2.0
> Reporter: Joe McDonnell
> Assignee: Lars Volker
> Priority: Critical
> Labels: broken-build
>
> An exhaustive run on centos 6 hit the following error:
> {noformat}
> custom_cluster/test_breakpad.py:319: in test_minidump_cleanup_thread
> assert self.wait_for_num_processes('impalad', cluster_size) ==
> cluster_size
> custom_cluster/test_breakpad.py:120: in wait_for_num_processes
> num_processes = self.get_num_processes(daemon)
> custom_cluster/test_breakpad.py:105: in get_num_processes
> self.cluster.refresh()
> common/impala_cluster.py:87: in refresh
> self.__build_impala_process_lists()
> common/impala_cluster.py:209: in __build_impala_process_lists
> cmdline = process.cmdline
> ../infra/python/env/lib/python2.6/site-packages/psutil/__init__.py:330: in
> cmdline
> return self._platform_impl.get_process_cmdline()
> ../infra/python/env/lib/python2.6/site-packages/psutil/_pslinux.py:437: in
> wrapper
> raise NoSuchProcess(self.pid, self._process_name)
> E NoSuchProcess: process no longer exists (pid=6572,
> name='impalad'){noformat}
> In looking at the logs, I don't see an impalad with that pid, so it would
> have to be a breakpad process.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
