[ 
https://issues.apache.org/jira/browse/IMPALA-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799181#comment-16799181
 ] 

ASF subversion and git services commented on IMPALA-8328:
---------------------------------------------------------

Commit 6436fc5fa3461b1e23a437a070c38e77d51ed1dc in impala's branch 
refs/heads/master from Austin Nobis
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6436fc5 ]

IMPALA-8328: Add missing ToSql test cases for authorization statements

ToSql test cases were added for the following authorization
statement classes: ShowRolesStmt, ShowGrantPrincipalStmt,
GrantRevokeRoleStmt, GrantRevokePrivStmt. In addition, the
ShowGrantPrincipalStmt::toSql, GrantRevokeRoleStmt::toSql, and
PrivilegeSpec::toSql statements were found to be incorrect during
testing and were updated to align with the grammar.

Testing:
- Ran all FE tests
- Added new tests to ToSqlTest for the listed statements

Change-Id: I828d0459b6c92f7f15006e2353ce108093aa9dab
Reviewed-on: http://gerrit.cloudera.org:8080/12817
Reviewed-by: Fredy Wijaya <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Add missing ToSql test cases for authorization statements
> ---------------------------------------------------------
>
>                 Key: IMPALA-8328
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8328
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 3.0, Impala 2.12.0
>            Reporter: Austin Nobis
>            Assignee: Austin Nobis
>            Priority: Major
>             Fix For: Impala 3.3.0
>
>
> The following authorization statements are missing tests in the ToSql test 
> class.
>  * GrantRevokePrivStmt
>  * GrantRevokeRoleStmt
>  * ShowGrantPrincipalStmt
>  * ShowRolesStmt



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to