[ 
https://issues.apache.org/jira/browse/IMPALA-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802002#comment-16802002
 ] 

ASF subversion and git services commented on IMPALA-8337:
---------------------------------------------------------

Commit ed9e1d499b3a3e6e30386dc11e55b6907eaaf409 in impala's branch 
refs/heads/master from Fredy Wijaya
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ed9e1d4 ]

IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337

Fixes in IMPALA-8317 and IMPALA-8337 introduced third-party dependencies
in Impala shell which is problematic in multi-Python environment. This
patch rewrites the fixes using an alternative solution when dealing with
duplicate options without any third-party dependencies. For example:

[impala]
keyval=msg1=hello,keyval=msg2=world

Testing:
- Ran all shell tests on Python 2.6 and 2.7.
- Ran make_shell_tarball.sh and ran Impala shell from the tarball
  without any issue.

Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Reviewed-on: http://gerrit.cloudera.org:8080/12844
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Dataload fails due to ImportError: cannot import name OrderedDict from 
> impala-shell
> -----------------------------------------------------------------------------------
>
>                 Key: IMPALA-8337
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8337
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Clients
>    Affects Versions: Impala 3.3.0
>            Reporter: Joe McDonnell
>            Assignee: Fredy Wijaya
>            Priority: Blocker
>              Labels: broken-build
>             Fix For: Impala 3.3.0
>
>
> Dataload on centos 6 (with Python 2.6) fails when running "Caching test 
> tables":
> {noformat}
> 15:14:59 ImportError: cannot import name OrderedDict
> 15:14:59 Traceback (most recent call last):
> 15:14:59   File 
> "/data/jenkins/workspace/impala-cdh6.x-exhaustive-centos6/repos/Impala/shell/impala_shell.py",
>  line 42, in <module>
> 15:14:59     from option_parser import get_option_parser, get_config_from_file
> 15:14:59   File 
> "/data/jenkins/workspace/impala-cdh6.x-exhaustive-centos6/repos/Impala/shell/option_parser.py",
>  line 34, in <module>
> 15:14:59     from collections import OrderedDict{noformat}
> Unfortunately, OrderedDict was introduced in Python 2.7 according to this 
> table:
> [https://docs.python.org/2/library/collections.html]
> Python 2.6 strikes again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to