[ 
https://issues.apache.org/jira/browse/IMPALA-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821310#comment-16821310
 ] 

ASF subversion and git services commented on IMPALA-8426:
---------------------------------------------------------

Commit 2ab23088849fa1da33e14b25816622837e50e99e in impala's branch 
refs/heads/master from Bharath Krishna
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=2ab2308 ]

IMPALA-8426: Logging error in DROP_TABLE event processing

Fixing the bug in condition check while logging in
DROP_TABLE event processing. Also updating EVENTS_SKIPPED
metric to keep track of the number of drop table events
skipped when CREATION_TIME matches.

Testing:
 - Added metric check to unit test.
 - Ran existing unit tests.

Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4
Reviewed-on: http://gerrit.cloudera.org:8080/13056
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Logging error in DROP_TABLE event processing.
> ---------------------------------------------
>
>                 Key: IMPALA-8426
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8426
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Bharathkrishna Guruvayoor Murali
>            Assignee: Bharathkrishna Guruvayoor Murali
>            Priority: Minor
>
> We have the following logging code in DROP_TABLE process() method, here 
> always the first condition is triggered and the second will never be matched. 
> So we should switch the order of the conditions.
> {code:java}
> if (!tblMatched.getRef()) {
> LOG.warn(debugString("Table %s was not removed from "
> + "catalog since the creation time of the table did not match", tblName_));
> } else if (!tblWasFound.getRef()) {
> debugLog("Table {} was not removed since it did not exist in catalog.", 
> tblName_);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to