[ https://issues.apache.org/jira/browse/IMPALA-8463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830408#comment-16830408 ]
ASF subversion and git services commented on IMPALA-8463: --------------------------------------------------------- Commit c6e3ea4846cc56bc2d941a07f2f29821d4b788d5 in impala's branch refs/heads/master from Tim Armstrong [ https://gitbox.apache.org/repos/asf?p=impala.git;h=c6e3ea4 ] IMPALA-8463: fix skip.header.line.count on local catalog This moves the logic to FeFsTable and calls it from LocalFsTable. Testing: Added a unit test that repros the problem. End-to-end tests run against local catalog will catch this but aren't enabled. Change-Id: I3957b3661574c356a14197e8829abbed92028a1a Reviewed-on: http://gerrit.cloudera.org:8080/13131 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> > skip.header.line.count ignored on local catalog > ----------------------------------------------- > > Key: IMPALA-8463 > URL: https://issues.apache.org/jira/browse/IMPALA-8463 > Project: IMPALA > Issue Type: Bug > Components: Catalog > Affects Versions: Impala 3.1.0, Impala 3.2.0, Impala 3.3.0 > Reporter: Tim Armstrong > Assignee: Tim Armstrong > Priority: Critical > > test_text_scanner_with_header() fails when run against local catalog. > {noformat} > [tarmstrong-box2.ca.cloudera.com:21000] functional> select c1, c2 from > table_with_header > > ; > Query: select c1, c2 from table_with_header > Query submitted at: 2019-04-25 22:47:52 (Coordinator: > http://2c766e5e2187:25000) > Query progress can be monitored at: > http://2c766e5e2187:25000/query_plan?query_id=68403d93ac914925:394ee6a100000000 > +------+------+ > | c1 | c2 | > +------+------+ > | 5 | 6 | > | 1 | 2 | > | 3 | 4 | > | NULL | NULL | > +------+------+ > WARNINGS: Error converting column: 0 to INT > Error converting column: 1 to DOUBLE > Error parsing row: file: > hdfs://172.19.0.1:20500/test-warehouse/table_with_header/table_with_header.csv, > before offset: 22 > {noformat} > This is suspicious in LocalFsTable.java > {code} > @Override > public int parseSkipHeaderLineCount(StringBuilder error) { > // TODO Auto-generated method stub > return 0; > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org