[ 
https://issues.apache.org/jira/browse/IMPALA-6777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835952#comment-16835952
 ] 

Bikramjeet Vig commented on IMPALA-6777:
----------------------------------------

I think the intention there was that memory is always printed as a single unit, 
eg: 1.23 KB, 10.1 MB, 12.00 GB. So the space looks ok there, whereas time is 
often printed as multiple units stacked together like 12s123ms so if we add a 
space there we will have to make it look like 12 s 123 ms to make the spacing 
consistent. Also, I am a lil wary that this might break some external parsers 
that monitor impala metrics or read profiles, so this can break compatibility.

Closing this since there is no strong incentive to change the representation.

> Whitespace inconsistencies in pretty printer across units
> ---------------------------------------------------------
>
>                 Key: IMPALA-6777
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6777
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 2.12.0
>            Reporter: Lars Volker
>            Priority: Trivial
>              Labels: newbie
>
> Depending on the unit we sometimes print a whitespace between a value and its 
> unit and sometimes we don't:
>  
> {noformat}
> "human_readable": "Count: 9, min / max: 13.000us / 22.000us, 25th %-ile: 
> 13.000us, 50th %-ile: 16.000us, 75th %-ile: 17.000us, 90th %-ile: 18.000us, 
> 95th %-ile: 22.000us, 99.9th %-ile: 22.000us",
> "human_readable": "Count: 9, min / max: 80.00 B / 80.00 B, 25th %-ile: 80.00 
> B, 50th %-ile: 80.00 B, 75th %-ile: 80.00 B, 90th %-ile: 80.00 B, 95th %-ile: 
> 80.00 B, 99.9th %-ile: 80.00 B",
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to