[
https://issues.apache.org/jira/browse/IMPALA-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Armstrong updated IMPALA-4233:
----------------------------------
Description:
FragmentInstanceState::Open() can fail if codegen of expressions fails:
{code}
// It shouldn't be fatal to fail codegen. However, until IMPALA-4233 is
fixed,
// ScalarFnCall has no fall back to interpretation when codegen fails so
propagates
// the error status for now.
RETURN_IF_ERROR(runtime_state_->CodegenScalarFns());
{code}
was:ScalarFnCall::Prepare() can fail if the codegen for the function fails
for some reason. Ideally we would want to move the codegen out of the Prepare()
method and would want to fall back to interpretation if the codegen fails.
Revisit the logic here.
> Revisit handling of codegen failed
> ----------------------------------
>
> Key: IMPALA-4233
> URL: https://issues.apache.org/jira/browse/IMPALA-4233
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 2.8.0
> Reporter: bharath v
> Assignee: Michael Ho
> Priority: Minor
> Labels: codegen
>
> FragmentInstanceState::Open() can fail if codegen of expressions fails:
> {code}
> // It shouldn't be fatal to fail codegen. However, until IMPALA-4233 is
> fixed,
> // ScalarFnCall has no fall back to interpretation when codegen fails
> so propagates
> // the error status for now.
> RETURN_IF_ERROR(runtime_state_->CodegenScalarFns());
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
