[
https://issues.apache.org/jira/browse/IMPALA-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883430#comment-16883430
]
Michael Ho commented on IMPALA-8740:
------------------------------------
Based on the profile, it seems the stats on one of the table has corrupted
stats:
{noformat}
E WARNING: The following tables have potentially corrupt table statistics.
E Drop and re-compute statistics to resolve this problem.
E functional.alltypes
{noformat}
Consequently, the logic for disabling codegen didn't get run at all:
{noformat}
private void checkForDisableCodegen(PlanNode distributedPlan) {
MaxRowsProcessedVisitor visitor = new MaxRowsProcessedVisitor();
distributedPlan.accept(visitor);
if (!visitor.valid()) return; <<----
// This heuristic threshold tries to determine if the per-node codegen time
will
// reduce per-node execution time enough to justify the cost of codegen.
Per-node
// execution time is correlated with the number of rows flowing through the
plan.
if (visitor.getMaxRowsProcessedPerNode()
< ctx_.getQueryOptions().getDisable_codegen_rows_threshold()) {
ctx_.getQueryCtx().disable_codegen_hint = true;
}
}
{noformat}
> TestCodegen.test_disable_codegen flakiness
> -------------------------------------------
>
> Key: IMPALA-8740
> URL: https://issues.apache.org/jira/browse/IMPALA-8740
> Project: IMPALA
> Issue Type: Bug
> Affects Versions: Impala 3.3.0
> Reporter: Anurag Mantripragada
> Assignee: Tim Armstrong
> Priority: Major
> Labels: broken-build
>
> Looks like the test cannot find "Codegen Disabled: disabled due to
> optimization hints" in the profile and fails the assertion:
> {code:java}
> query_test/test_codegen.py:44: in test_disable_codegen
> self.run_test_case('QueryTest/disable-codegen', vector)
> common/impala_test_suite.py:617: in run_test_case
> update_section=pytest.config.option.update_results)
> common/test_result_verifier.py:605: in verify_runtime_profile
> actual))
> E AssertionError: Did not find matches for lines in runtime profile:
> E EXPECTED LINES:
> E row_regex: .*Codegen Disabled: disabled due to optimization hints.*
> ...
> ACTUAL PROFILE FOLLOWS{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
