[
https://issues.apache.org/jira/browse/IMPALA-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896626#comment-16896626
]
ASF subversion and git services commented on IMPALA-8785:
---------------------------------------------------------
Commit def70c241dffcdab8301cbc7456ea6680ca01692 in impala's branch
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=def70c2 ]
IMPALA-8785: give debug docker images a different name
* Build scripts are generalised to have different targets for release
and debug images.
* Added new targets for the debug images: docker_debug_images,
statestored_debug images. The release images still have the
same names.
* Separate build contexts are set up for the different base
images.
* The debug or release base image can be specified as the FROM
for the daemon images.
* start-impala-cluster.py picks the correct images for the build type
Future work:
We would like to generalise this to allow building from
non-ubuntu-16.04 base images. This probably requires another
layer of dockerfiles to specify a base image for impala_base
with the required packages installed.
Change-Id: I32d2e19cb671beacceebb2642aba01191bd7a244
Reviewed-on: http://gerrit.cloudera.org:8080/13905
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> DEBUG build images should be tagged differently from release build
> ------------------------------------------------------------------
>
> Key: IMPALA-8785
> URL: https://issues.apache.org/jira/browse/IMPALA-8785
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 3.3.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Critical
> Labels: docker
>
> Currently the container build gives debug and release images the same tag
> names. This is fine for development, since you'll generally be working on one
> build at a time, but is confusing if you need to integrate this into a more
> general build process, since debug and release images are really separate
> artifacts.
> One example I ran into is a case when I ran ./buildall.sh ...
> -release_and_debug, then wanted to build docker images for the release
> artifacts. This is not currently possible in a sane way.
> I think we should tag images with a -debug suffix if they were generated from
> debug artifacts. start-impala-cluster would need to be smart about picking
> the image to use. We may want to have different build targets to build the
> different flavours of image, too.
> Note that there are many flavours of debug images, e.g. ASAN, but I think
> simply separating release and debug would avoid a lot of confusion.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
