[
https://issues.apache.org/jira/browse/IMPALA-8850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904540#comment-16904540
]
ASF subversion and git services commented on IMPALA-8850:
---------------------------------------------------------
Commit f34a243a956dacd52f8afe79a122410ccf45ae26 in impala's branch
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f34a243 ]
IMPALA-8850: is_percent not initialized in TmpFileMgr parser
This bug was only detected on ASAN. The is_percent variable
was not initialised and is not set in ParseMemSpec() when it
does an early exit for an empty string. This caused
TmpFileMgr to consider the empty memory spec after the colon
to be invalid.
Testing:
This reliably reproduced in TmpFileMgrTest under ASAN.
Initialising is_percent fixed the issue.
Added more detailed tests for ParseMemSpec() that initialise
is_percent to avoid similar bugs.
Change-Id: I4465944c7043c1fc6b33db9693ec290c24e3ed19
Reviewed-on: http://gerrit.cloudera.org:8080/14040
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> TmpFileMgrTest.TestDirectoryLimitParsing failed in asf-master build with
> error "Value of: dirs3.size() Actual: 3 Expected: 4"
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: IMPALA-8850
> URL: https://issues.apache.org/jira/browse/IMPALA-8850
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 3.3.0
> Reporter: Xiaomeng Zhang
> Assignee: Tim Armstrong
> Priority: Blocker
> Labels: broken-build
>
> {code:java}
> Error Message
> Value of: dirs3.size() Actual: 3 Expected: 4
> Stacktrace
> /data/jenkins/workspace/impala-asf-master-core-asan/repos/Impala/be/src/runtime/tmp-file-mgr-test.cc:834
> Value of: dirs3.size()
> Actual: 3
> Expected: 4
> {code}
> Looks like due to commitÂ
> [https://github.com/apache/impala/commit/411189a8d733a66c363c72f8c404123d68640a3e]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
