[ 
https://issues.apache.org/jira/browse/IMPALA-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908107#comment-16908107
 ] 

ASF subversion and git services commented on IMPALA-8864:
---------------------------------------------------------

Commit fafb2c9786467ebe582b92b27e2990f5789c9c00 in impala's branch 
refs/heads/master from Bharath Vissapragada
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=fafb2c9 ]

IMPALA-8864: Handle py ssl library incompatibility in http mode

Older python versions shipped ssl libraries that did not implement
SSLContext class. THttpClient relies on it. This patch,

- Fails the shell gracefully when such a python version is used.
- Skips the http test dimension when running the test suite on a
machine that ships such a python verison (centos 6).

Change-Id: I28846bde0b8bb8f787e6330cddf91645dba4160e
Reviewed-on: http://gerrit.cloudera.org:8080/14069
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com>


> Shell tests in http mode fail on CentOS 6
> -----------------------------------------
>
>                 Key: IMPALA-8864
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8864
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Clients
>            Reporter: bharath v
>            Assignee: bharath v
>            Priority: Major
>              Labels: broken-build
>
> {noformat}
> Error MessageAssertionError: Cmd ['--ssl', '-q', 'select 1 + 2'] was expected 
> to succeed: Starting Impala Shell without Kerberos authentication SSL is 
> enabled. Impala server certificates will NOT be verified (set --ca_cert to 
> change) Warning: --connect_timeout_ms is currently ignored with HTTP 
> transport. Error connecting: AttributeError, 'module' object has no attribute 
> 'create_default_context' Not connected to Impala, could not execute 
> queries.Stacktracecustom_cluster/test_client_ssl.py:90: in test_ssl
>     self._validate_positive_cases(vector, "%s/server-cert.pem" % 
> self.CERT_DIR)
> custom_cluster/test_client_ssl.py:235: in _validate_positive_cases
>     result = run_impala_shell_cmd(vector, shell_options, 
> wait_until_connected=False)
> shell/util.py:113: in run_impala_shell_cmd
>     result.stderr)
> E   AssertionError: Cmd ['--ssl', '-q', 'select 1 + 2'] was expected to 
> succeed: Starting Impala Shell without Kerberos authentication
> E   SSL is enabled. Impala server certificates will NOT be verified (set 
> --ca_cert to change)
> E   Warning: --connect_timeout_ms is currently ignored with HTTP transport.
> E   Error connecting: AttributeError, 'module' object has no attribute 
> 'create_default_context'
> E   Not connected to Impala, could not execute queries.
> {noformat}
> ssl library in python does not have the required methods that the THttpClient 
> relies on.
> {noformat}
> [centos6 ~]# python
> Python 2.6.6 (r266:84292, Jul 10 2013, 22:48:45) 
> [GCC 4.4.7 20120313 (Red Hat 4.4.7-3)] on linux2
> Type "help", "copyright", "credits" or "license" for more information.
> >>> 
> >>> import ssl;
> >>> ctx = ssl.create_default_context(Purpose.CLIENT_AUTH)
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
> AttributeError: 'module' object has no attribute 'create_default_context'
> {noformat}
> While the page [1]  says "It was added in 2.7.9 and newer.". It appears that 
> it was backported to a few older versions shipped by linux vendors (although 
> I was not able to narrow down the exact change log).
> {noformat}
> [centos 7.3 ~]# python
> Python 2.7.5 (default, Jun 20 2019, 20:27:34) 
> [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)] on linux2
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import ssl;
> >>> ctx = ssl.create_default_context();
> >>> 
> {noformat}
> [1] https://docs.python.org/2/library/ssl.html#ssl.create_default_context



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to