[ 
https://issues.apache.org/jira/browse/IMPALA-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908144#comment-16908144
 ] 

ASF subversion and git services commented on IMPALA-8849:
---------------------------------------------------------

Commit c3a67b67faaebf18735fa36d35c80d8c11043f7f in impala's branch 
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=c3a67b6 ]

IMPALA-8849: fix IllegalStateException with VARCHAR

The bug is that the serialized size wasn't populated
for VARCHAR in a case when it should have been.
It appears a condition was simply not updated when
VARCHAR was added.

Other code assumed that the serialized size was
populated when the other size field was populated,
which is a reasonable invariant. I documented the
invariant in the class and added validation that
the invariant held.

Defining and checking invariants led to discovering
various other minor issues where the sizes were
set incorrect for fixed-length types or not set for
variable-length types:
* CHAR was not consistently treated as a fixed-length type.
* avgSerializedSize_ was not always updated with avgSize_

Testing:
Added a regression test for this specific case. Adding
the assertions resulted in other cases showing up
related bugs.

Change-Id: Ie45e386cb09e31f4b7cdc82b7734dbecb4464534
Reviewed-on: http://gerrit.cloudera.org:8080/14062
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Reviewed-by: Csaba Ringhofer <csringho...@cloudera.com>


> IllegalStateException in HashJoinNode because of missing memory estimate
> ------------------------------------------------------------------------
>
>                 Key: IMPALA-8849
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8849
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Frontend
>    Affects Versions: Impala 3.3.0
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Blocker
>             Fix For: Impala 3.3.0
>
>         Attachments: query4.sql
>
>
> [~grahn] reports the below error when running the attached TPC-DS query on 
> uncompressed text with stats.
> {noformat}
> I0808 03:27:16.621085 150090 jni-util.cc:288] 
> 8945e9f76f33dca0:8bf31c4700000000] java.lang.IllegalStateException: Mem 
> estimate must be set
>     at com.google.common.base.Preconditions.checkState(Preconditions.java:149)
>     at 
> org.apache.impala.planner.ResourceProfileBuilder.build(ResourceProfileBuilder.java:73)
>     at 
> org.apache.impala.planner.HashJoinNode.computeNodeResourceProfile(HashJoinNode.java:252)
>     at 
> org.apache.impala.planner.PlanFragment.computeResourceProfile(PlanFragment.java:238)
>     at org.apache.impala.planner.Planner.computeResourceReqs(Planner.java:416)
>     at 
> org.apache.impala.service.Frontend.createExecRequest(Frontend.java:1162)
>     at 
> org.apache.impala.service.Frontend.getPlannedExecRequest(Frontend.java:1477)
>     at 
> org.apache.impala.service.Frontend.doCreateExecRequest(Frontend.java:1341)
>     at org.apache.impala.service.Frontend.getTExecRequest(Frontend.java:1236)
>     at 
> org.apache.impala.service.Frontend.createExecRequest(Frontend.java:1206)
>     at 
> org.apache.impala.service.JniFrontend.createExecRequest(JniFrontend.java:154)
> I0808 03:27:16.621861 150090 status.cc:124] 
> 8945e9f76f33dca0:8bf31c4700000000] IllegalStateException: Mem estimate must 
> be set
>     @           0xb9af99
>     @          0x11f785e
>     @          0x10ab9a3
>     @          0x10d0f54
>     @          0x10e2a2c
>     @          0x1125f8d
>     @          0x1458c54
>     @          0x145810c
>     @           0xb68769
>     @           0xf91ca0
>     @           0xf8791e
>     @           0xf887b1
>     @          0x127cd2f
>     @          0x127d8d9
>     @          0x1ac0709
>     @     0x7f11ea4d7dd4
>     @     0x7f11e6f1e02c
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to