[
https://issues.apache.org/jira/browse/IMPALA-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921073#comment-16921073
]
Sahil Takiar commented on IMPALA-7351:
--------------------------------------
[~bikramjeet.vig] memory estimates for IMPALA-4268 were added in IMPALA-8818 -
[https://github.com/apache/impala/blob/b7dfc18c59e831fa265d14ef4f7d26e33120b67f/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java#L68]
When result spooling is disabled, the reservation is still set to
{{ResourceProfile.noReservation(0)}} since no rows are actually buffered. Do we
think that there should be a reservation for {{PlanRootSink}} when result
spooling is disabled as well?
> Add memory estimates for plan nodes and sinks with missing estimates
> --------------------------------------------------------------------
>
> Key: IMPALA-7351
> URL: https://issues.apache.org/jira/browse/IMPALA-7351
> Project: IMPALA
> Issue Type: Sub-task
> Components: Frontend
> Reporter: Tim Armstrong
> Assignee: Bikramjeet Vig
> Priority: Major
> Labels: admission-control, resource-management
>
> Many plan nodes and sinks, e.g. KuduScanNode, KuduTableSink, ExchangeNode,
> etc are missing memory estimates entirely.
> We should add a basic estimate for all these cases based on experiments and
> data from real workloads. In some cases 0 may be the right estimate (e.g. for
> streaming nodes like SelectNode that just pass through data) but we should
> remove TODOs and document the reasoning in those cases.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
