[
https://issues.apache.org/jira/browse/IMPALA-8944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931788#comment-16931788
]
Sahil Takiar edited comment on IMPALA-8944 at 9/17/19 8:20 PM:
---------------------------------------------------------------
I've got 14 of the original 19 unit tests in {{S3PlannerTest}} working. Instead
of relying on a test filter in {{run-all-tests.sh}}, I decided to use JUnit
Categories and Maven profiles to select the tests to run (achieves a similar
affect as TestNG Groups). I think it is a more robust and straightforward way
of running tests. Now any fe/ tests that should be run for S3 can simply be
tagged with the Java annotation {{@Category(S3Tests.class)}}.
The failing {{S3PlannerTest}}-s are:
* org.apache.impala.planner.S3PlannerTest.testTpcds
* org.apache.impala.planner.S3PlannerTest.testTpch
* org.apache.impala.planner.S3PlannerTest.testJoinOrder
* org.apache.impala.planner.S3PlannerTest.testSubqueryRewrite
All are failing for non-trivial reasons - e.g. actual differences in the
explain plans when running on S3 vs. HDFS data (e.g. differences in memory
estimates, join orders, etc.). I've opened IMPALA-8949 to investigate this.
{{testS3ScanRanges()}} is failing as well, but for other reasons described
above.
was (Author: stakiar):
I've got 14 of the original 17 unit tests in {{S3PlannerTest}} working. Instead
of relying on a test filter in {{run-all-tests.sh}}, I decided to use JUnit
Categories and Maven profiles to select the tests to run (achieves a similar
affect as TestNG Groups). I think it is a more robust and straightforward way
of running tests. Now any fe/ tests that should be run for S3 can simply be
tagged with the Java annotation {{@Category(S3Tests.class)}}.
The failing {{S3PlannerTest}}-s are:
* org.apache.impala.planner.S3PlannerTest.testTpcds
* org.apache.impala.planner.S3PlannerTest.testTpch
* org.apache.impala.planner.S3PlannerTest.testJoinOrder
* org.apache.impala.planner.S3PlannerTest.testSubqueryRewrite
All are failing for non-trivial reasons - e.g. actual differences in the
explain plans when running on S3 vs. HDFS data (e.g. differences in memory
estimates, join orders, etc.). I've opened IMPALA-8949 to investigate this.
> Update and re-enable S3PlannerTest
> ----------------------------------
>
> Key: IMPALA-8944
> URL: https://issues.apache.org/jira/browse/IMPALA-8944
> Project: IMPALA
> Issue Type: Test
> Reporter: Sahil Takiar
> Assignee: Sahil Takiar
> Priority: Major
>
> It looks like we don't run {{S3PlannerTest}} in our regular Jenkins jobs.
> When run against a HDFS mini-cluster, they are skipped because the
> {{TARGET_FILESYSTEM}} is not S3. On our S3 jobs, they don't run either
> because we skip all fe/ tests (most of them don't work against S3 / assume
> they are running on HDFS).
> A few things need to be fixed to get this working:
> * The test cases in {{S3PlannerTest}} need to be fixed
> * The Jenkins jobs that runs the S3 tests needs the ability to run specific
> fe/ tests (e.g. just the {{S3PlannerTest}} and to skip the rest)
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
