[
https://issues.apache.org/jira/browse/IMPALA-8950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951826#comment-16951826
]
ASF subversion and git services commented on IMPALA-8950:
---------------------------------------------------------
Commit b0b8f20267f96c902eee5bab85475ee41645bbe3 in impala's branch
refs/heads/master from Sahil Takiar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b0b8f20 ]
IMPALA-8950: Set overwrite to False by default in fs_client.copy
test_udfs.py and test_load.py are consistently failing on S3 with
the following error:
E TypeError: copy() takes exactly 4 arguments (3 given)
The issue is that a new parameter 'overwrite' was added to the method
'HadoopFsCommandLineClient.copy', but with no default value. This patch
fixes the issue by adding 'overwrite=False'.
Testing:
* Ran core tests on S3
Change-Id: I1935e0c92f7402e727ee16596485147cf1a5a516
Reviewed-on: http://gerrit.cloudera.org:8080/14432
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Add -d and -f option to copyFromLocal and re-enable disabled S3 tests
> ---------------------------------------------------------------------
>
> Key: IMPALA-8950
> URL: https://issues.apache.org/jira/browse/IMPALA-8950
> Project: IMPALA
> Issue Type: Test
> Reporter: Sahil Takiar
> Assignee: Sahil Takiar
> Priority: Major
> Fix For: Impala 3.4.0
>
>
> The {{-d}} option for {{hdfs dfs -copyFromLocal}} "Skip[s] creation of
> temporary file with the suffix ._COPYING_". The {{-f}} option "Overwrites the
> destination if it already exists".
> By using the {{-d}} option, copies to S3 avoid the additional overhead of
> copying data to a tmp file and then renaming the file. The {{-f}} option
> overwrites the file if it exists, which should be safe since tests should be
> writing to unique directories anyway. With HADOOP-16490,
> {{create(overwrite=true)}} avoids issuing a HEAD request on the path, which
> prevents any cached 404s on the S3 key.
> After these changes, the tests disabled by IMPALA-8189 can be re-enabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
