[
https://issues.apache.org/jira/browse/IMPALA-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960200#comment-16960200
]
ASF subversion and git services commented on IMPALA-9065:
---------------------------------------------------------
Commit 9100a98273aa840dc6781c446757b97db50c8b47 in impala's branch
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=9100a98 ]
IMPALA-9065: don't block indefinitely for filters
This patch ensures that query cancellation will
promptly wake up any threads blocked waiting for runtime
filters to arrive. Before this patch, threads would
wait for up to RUNTIME_FILTER_WAIT_TIME_MS after the
query was cancelled.
Testing:
* Add a cancellation test with a high runtime filter wait time
that reproduces the threads getting stuck. This test
failed reliably without the code changes.
* Also update metric verification to check that no fragments
are left running when tests are finished.
* Ran exhaustive tests.
* Ran a 10000 query TPC-H Kudu and TPC-DS Parquet stress test on
a minicluster with 3 impalads.
Change-Id: I0a70e4451c2b48c97f854246e90b71f6e5d67710
Reviewed-on: http://gerrit.cloudera.org:8080/14499
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Fix cancellation of RuntimeFilter::WaitForArrival()
> ---------------------------------------------------
>
> Key: IMPALA-9065
> URL: https://issues.apache.org/jira/browse/IMPALA-9065
> Project: IMPALA
> Issue Type: Sub-task
> Components: Distributed Exec
> Affects Versions: Impala 3.3.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
>
> Proper cancellation wasn't ever implemented for this code path, so if the
> wait time is set high, threads can get blocked indefinitely even if the
> coordinator cancelled the query.
> I don't think it's hard to do the right thing - signal the filter and wake
> up the thread when the finstance is cancelled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
