Joe McDonnell created IMPALA-9100:
-------------------------------------

             Summary: tests/run-tests.py should handle duplicate --skip-stress 
flags
                 Key: IMPALA-9100
                 URL: https://issues.apache.org/jira/browse/IMPALA-9100
             Project: IMPALA
          Issue Type: Bug
          Components: Infrastructure
    Affects Versions: Impala 3.4.0
            Reporter: Joe McDonnell


If you pass --skip-stress multiple times to tests/run-tests.py, only the first 
is removed before the arguments are passed to pytest:
{noformat}
  skip_stress = '--skip-stress' in sys.argv
  if skip_stress:
    sys.argv.remove("--skip-stress"){noformat}
This is also true for skip_serial and skip_parallel.

This matters for the docker-based tests, because the docker-based tests run the 
serial end-to-end tests with --skip-stress specified. run-all-tests.sh also 
adds a --skip-stress argument when running core tests:
{noformat}
if [[ "${EXPLORATION_STRATEGY}" == "core" ]]; then
  # Skip the stress test in core - all stress tests are in exhaustive and
  # pytest startup takes a significant amount of time.
  RUN_TESTS_ARGS+=" --skip-stress"
fi{noformat}
Only one skip-stress is removed, and the other one gets passed to pytest, which 
immediately fails without running tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to