[
https://issues.apache.org/jira/browse/IMPALA-8879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963671#comment-16963671
]
ASF subversion and git services commented on IMPALA-8879:
---------------------------------------------------------
Commit d08d1956cc65cee2d9d5558eac38b0562e93fcab in impala's branch
refs/heads/master from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=d08d195 ]
IMPALA-8879: Fix wrong active tabs after bootstrap upgrade
After upgrading Bootstrap to 4.3.1 in the previous patch, the query page
no longer highlights which tab is being used. This is due to the removal
of ".nav-tabs > li.active > a" in bootstrap.css. So li elements in
"active" class no longer has additional styles. Instead, the styles of
"active" class is moved into to "nav-link" class in Bootstrap 4. We
should add the "active" class in the "nav-link" elements instead.
Tests:
- Manually click throught all tabs to check the active state
Change-Id: I5c746bc4f49b30df54bd3c73ac6f1cf838260c65
Reviewed-on: http://gerrit.cloudera.org:8080/14582
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Upgrade bootstrap.js
> --------------------
>
> Key: IMPALA-8879
> URL: https://issues.apache.org/jira/browse/IMPALA-8879
> Project: IMPALA
> Issue Type: Task
> Components: Frontend
> Affects Versions: Impala 3.3.0
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
> Fix For: Impala 3.4.0
>
>
> The version we're using is quite out-of-date.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
