[
https://issues.apache.org/jira/browse/IMPALA-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969982#comment-16969982
]
ASF subversion and git services commented on IMPALA-9093:
---------------------------------------------------------
Commit 050dcf912e31924c1ebe122ab19b51e9e0af7bf7 in impala's branch
refs/heads/master from Gabor Kaszab
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=050dcf9 ]
IMPALA-9093: Change ACID tests to upgrade external tables
Due to Hive-22158 all non-ACID tables are treated as external tables
instead of being managed tables. The ACID tests occasionally upgrade
non-ACID tables to ACID tables but that is not allowed for external
tables. Since all non-ACID tables are external due to HIVE-22158 some
of the ACID tests started to fail after a CDP_BUILD_NUMBER bump that
brought in a Hive version containing the mentioned change.
The fix is to set 'EXTERNAL' table property to false in the same step
when upgrading the table to ACID. Also in the tests this step is
executed from HIVE instead of Impala.
Tested with the original CDP_BUILD_NUMBER in bin/impala-config.sh and
also tested after bumping that number to 1579022.
Change-Id: I796403e04b3f06c99131db593473d5438446d5fd
Reviewed-on: http://gerrit.cloudera.org:8080/14633
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Gabor Kaszab <[email protected]>
> Fix ACID upgrade tests to account for HIVE-22158 (table translation)
> --------------------------------------------------------------------
>
> Key: IMPALA-9093
> URL: https://issues.apache.org/jira/browse/IMPALA-9093
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
> Affects Versions: Impala 3.4.0
> Reporter: Joe McDonnell
> Assignee: Gabor Kaszab
> Priority: Blocker
> Fix For: Impala 3.4.0
>
>
> There are tests that create a normal managed table and upgrade that table to
> a transactional table. For example, in test_acid.py, we run acid.test, which
> has:
> {noformat}
> create table upgraded_table (x int);
> insert into upgraded_table values (1);
> # Upgrade to the table to insert only acid when there are already values in
> it.
> alter table upgraded_table set tblproperties
> ('transactional' = 'true', 'transactional_properties' = 'insert_only');
> insert into upgraded_table values (2);
> insert into upgraded_table values (3);{noformat}
> With HIVE-22158, the create table is now translated to an external table, and
> this now fails with:
> {noformat}
> E ImpalaBeeswaxException: ImpalaBeeswaxException:
> E INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>
> E MESSAGE: ImpalaRuntimeException: Error making 'alter_table' RPC to Hive
> Metastore:
> E CAUSED BY: MetaException: test_acid_basic_5d04240b.upgraded_table cannot
> be declared transactional because it's an external table{noformat}
> If external tables can't be upgraded and all managed tables are now external,
> then this test case is invalid and can be removed. We should make sure that
> this is how it is supposed to work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
