[ 
https://issues.apache.org/jira/browse/IMPALA-8065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982183#comment-16982183
 ] 

ASF subversion and git services commented on IMPALA-8065:
---------------------------------------------------------

Commit ae2425241d51ac5b9559401faa3c66c694f0fd1c in impala's branch 
refs/heads/master from xiaomeng
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ae24252 ]

IMPALA-8065: Add OS distribution name in OSInfo

Before this change OsInfo::DebugString() would print two lines:
- OS version: the long name of the Linux kernel from /proc/version
- Clock: the type of clock used
After this change OsInfo::DebugString() will print three lines:
- OS distribution: the short name of the OS release.
  If Docker is being used this is the name of the Container OS.
- OS version: the long name of the Linux kernel from /proc/version.
  If Docker is being used this is the description of the Host Kernel.
- Clock: the type of clock used.

Tested locally, the displayed OS Info in Ubuntu16 dev box is:
OS distribution: Ubuntu 16.04.6 LTS
OS version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017)
(gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10))
Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC

Also checked with diff OS in docker: centos, redhat, ubuntu, oracle,
debian to make sure /etc/os-release exists and PRETTY_NAME in that file.
Each OS picked one version to test.
Specially for centos6 and redhat6, which have redhat-release instead of
os-release, copied redhat-release into Ubuntu16 dev box and verified os
version in mini-cluster.

Added new backend test os-info-test.cc.

Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Reviewed-on: http://gerrit.cloudera.org:8080/14531
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> OSInfo produces somewhat misleading output when running in container
> --------------------------------------------------------------------
>
>                 Key: IMPALA-8065
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8065
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>    Affects Versions: Impala 3.1.0
>            Reporter: Tim Armstrong
>            Assignee: Xiaomeng Zhang
>            Priority: Critical
>
> It uses /proc/version, which returns the host version. It would be good to 
> also get the version from lsb-release from the Ubuntu container we're running 
> in and disambiguate on the debug page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to