[
https://issues.apache.org/jira/browse/IMPALA-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989233#comment-16989233
]
ASF subversion and git services commented on IMPALA-9215:
---------------------------------------------------------
Commit 92aa2c16f172cf15cf6b026ab7af9c72576772f5 in impala's branch
refs/heads/master from Zoltan Borok-Nagy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=92aa2c1 ]
IMPALA-9215: report_benchmark_results.py fails with missing key
report_benchmark_results.py failed with missing key because it tried
to lookup 'num_instances' from the perf result json file. The JSON
file contained exec summary generated by
impala_beeswax.py::__build_summary_table() which omitted number of
instances.
This patch adds 'num_instances' to the summary table created by
impala_beeswax.py.
To keep report_benchmark_results.py simple it assumes that both perf
json files contain 'num_instances', i.e. if a user issues
single_node_perf_run.py to compare two commits, both of them must
contain this fix.
I tested the PS manually.
Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
Reviewed-on: http://gerrit.cloudera.org:8080/14830
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> report_benchmark_results.py fails with missing key
> --------------------------------------------------
>
> Key: IMPALA-9215
> URL: https://issues.apache.org/jira/browse/IMPALA-9215
> Project: IMPALA
> Issue Type: Bug
> Reporter: Zoltán Borók-Nagy
> Assignee: Zoltán Borók-Nagy
> Priority: Major
>
> IMPALA-4618 added "number of instances" (#Inst / num_instances) to exec
> summary. report_benchmark_results.py tries to look it up from the
> <perf_results>.json file, but the file doesn't have that field.
> The file contents are created via
> tests/beeswax/impala_beeswax.py::__build_summary_table() which omits "number
> of instances".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
