[
https://issues.apache.org/jira/browse/IMPALA-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013036#comment-17013036
]
ASF subversion and git services commented on IMPALA-4192:
---------------------------------------------------------
Commit 641e2abf2985972f96a1f27b94758c7bf26e64d5 in impala's branch
refs/heads/master from Bikramjeet Vig
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=641e2ab ]
IMPALA-4192: Move static state from DataSink into a DataSinkConfig
This patch adds a new class called DataSinkConfig which contains a
subset of the static state of their corresponding DataSink, of
which there is one instance per fragment. DataSink contains the
runtime state and there can be up to MT_DOP instances of it per
fragment.
Eventually all static state including codegened function pointers
would be moved to the PlanNodes.
Testing:
Ran exhaustive tests successfully.
Change-Id: I8d5b4226f6cec5305b0ec9a25c5f18b5521c8dd2
Reviewed-on: http://gerrit.cloudera.org:8080/14941
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Pull all expressions in a fragment into QueryState
> --------------------------------------------------
>
> Key: IMPALA-4192
> URL: https://issues.apache.org/jira/browse/IMPALA-4192
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend
> Affects Versions: Impala 2.8.0
> Reporter: Michael Ho
> Assignee: Bikramjeet Vig
> Priority: Major
> Labels: codegen
>
> Currently, Exprs in a fragment are scattered through the TPlanNode in a
> fragment. Expr is supposed to be shared by all threads but they are always
> accessed through thread-private state ExprContext. With multi-threading, an
> Expr in a fragment and its generated IR function should be shared among all
> instances of it.
> As part of IMPALA-4080, all Expr in a fragment will be moved to query-wide
> state instead of having multiple copies of them in the exec nodes of each
> instances. In addition, moving Expr to query-wide state prevents the mistakes
> of baking in thread private states (e.g. ExprContext pointers) into the
> generated IR code for an Expr.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
