[
https://issues.apache.org/jira/browse/IMPALA-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014709#comment-17014709
]
ASF subversion and git services commented on IMPALA-9267:
---------------------------------------------------------
Commit a36e2c9c5eb313f5fddb08a52382ca3237397706 in impala's branch
refs/heads/master from Sahil Takiar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a36e2c9 ]
IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState
Fixes a DCHECK in ClientRequestState::UpdateNonErrorExecState where the
ClientRequestState ExecState attempts to transition from the ERROR to
the FINISHED state. The DCHECK was added in IMPALA-6894 in order to
prevent any invalid state transition attempts.
The fix is to modify UpdateNonErrorExecState so that it skips any
attempt to transition from the ERROR to the FINISHED state, which is in
line with the behavior prior to IMPALA-6894.
Testing:
* Ran core tests, unable to reproduce the original issue locally
Change-Id: Ie47444ed67704d9469310727eeec2e9a66516e77
Reviewed-on: http://gerrit.cloudera.org:8080/14991
Reviewed-by: Thomas Tauber-Marshall <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Impala hits DCHECK in ClientRequestState due to invalid state transition
> ------------------------------------------------------------------------
>
> Key: IMPALA-9267
> URL: https://issues.apache.org/jira/browse/IMPALA-9267
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 3.4.0
> Reporter: Joe McDonnell
> Assignee: Sahil Takiar
> Priority: Blocker
> Labels: broken-build
> Attachments: backtrace.txt
>
>
> Some test runs see the coordinator Impalad hit this DCHECK:
> {code:java}
> case ExecState::FINISHED:
> // A query can transition from PENDING to FINISHED if it is cancelled by the
> // client.
> DCHECK(old_state == ExecState::PENDING || old_state == ExecState::RUNNING)
> << Substitute(
> error_msg, ExecStateToString(old_state),
> ExecStateToString(new_state));
> UpdateExecState(new_state);
> break;{code}
> The error message is:
> {noformat}
> F1222 23:01:14.020613 10494 client-request-state.cc:951] Check failed:
> old_state == ExecState::PENDING || old_state == ExecState::RUNNING Illegal
> state transition: ERROR -> FINISHED{noformat}
> This happened on one exhaustive run on Centos6 and an s3 run. There doesn't
> seem to be a pattern, so I'm assuming this is a generic issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
