[
https://issues.apache.org/jira/browse/IMPALA-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030275#comment-17030275
]
Sahil Takiar commented on IMPALA-6259:
--------------------------------------
Unfortunately, while this was fixed for ASAN and LSAN in
[https://reviews.llvm.org/rL308064] it wasn't fixed for TSAN until LLVM 6.0.0 -
[https://reviews.llvm.org/D35690#change-Z4hDHMmj5Vko]
[https://github.com/llvm/llvm-project/commit/132689243e03b4e817aaac82d352a029216e9fee]
> Remove workaround for posix_memalign in SystemAllocator after LLVM 5.0 upgrade
> ------------------------------------------------------------------------------
>
> Key: IMPALA-6259
> URL: https://issues.apache.org/jira/browse/IMPALA-6259
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 2.11.0
> Reporter: Tim Armstrong
> Assignee: Sahil Takiar
> Priority: Major
>
> Once we upgrade to LLVM 5.0 we should be able to remove a workaround for
> https://bugs.llvm.org/show_bug.cgi?id=32968 :
> {code}
> #ifdef ADDRESS_SANITIZER
> // Workaround ASAN bug where posix_memalign returns 0 even when allocation
> fails.
> // It should instead return ENOMEM. See
> https://bugs.llvm.org/show_bug.cgi?id=32968.
> if (rc == 0 && *buffer_mem == nullptr && len != 0) rc = ENOMEM;
> #endif
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
