[
https://issues.apache.org/jira/browse/IMPALA-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034605#comment-17034605
]
Tim Armstrong commented on IMPALA-9373:
---------------------------------------
Notes so far:
* In many cases it recommends including internal headers instead of the
public-facing header
* It gets confused by "using" statements in headers, e.g. it thinks
gutil/strings/substitute.h is needed for references to "string"
* The recommendations are mostly pretty good, but there were various small
misfires, e.g. recommendations that didn't work or match our coding standards
> Trial run of IWYU on codebase
> -----------------------------
>
> Key: IMPALA-9373
> URL: https://issues.apache.org/jira/browse/IMPALA-9373
> Project: IMPALA
> Issue Type: Sub-task
> Components: Infrastructure
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
>
> I did a trial run and implemented some of the suggestions of IWYU to confirm
> that it made sense. I'll post a patch with the changes and leave notes here.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
