[
https://issues.apache.org/jira/browse/IMPALA-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042268#comment-17042268
]
Tim Armstrong commented on IMPALA-8013:
---------------------------------------
IMPALA-8013: switch from boost to std locks
The locks are mostly drop-in replacements that wrap
the same pthread implementations.
I went through all of the boost mutex/lock/thread-related
includes and updated them so that the boost mutex headers
are not pulled in. E.g. <boost/thread.hpp> is an uber-header
that pulls in *all* of the boost mutex and thread headers.
std::shared_lock doesn't exist until c++17, so we don't
replace this.
Compile Time:
I confirmed that preprocessed files got slightly shorter,
which translated into a slight compile time improvement
for a full build.
Before:
real 9m27.502s
user 64m39.775s
sys 2m49.002s
After:
real 9m19.071s
user 63m13.950s
sys 2m45.066s
Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Reviewed-on: http://gerrit.cloudera.org:8080/15208
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Switch from boost:: to std:: locks
> ----------------------------------
>
> Key: IMPALA-8013
> URL: https://issues.apache.org/jira/browse/IMPALA-8013
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Tim Armstrong
> Priority: Trivial
> Labels: newbie
>
> We use boost::unique_lock, boost::lock_guard, boost::mutex, etc throughout
> the backend. There are now standard library equivalents. It would be good to
> switch to them and remove the dependency on that part of boost.
> We need to wait for c++17 support for shared_mutex. All others are available
> in gcc 4.9.2
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
