Vihang Karajgaonkar created IMPALA-9468:
-------------------------------------------
Summary: Refactor Table and Db code to have a Lockable interface
Key: IMPALA-9468
URL: https://issues.apache.org/jira/browse/IMPALA-9468
Project: IMPALA
Issue Type: Task
Reporter: Vihang Karajgaonkar
Assignee: Vihang Karajgaonkar
In https://issues.apache.org/jira/browse/IMPALA-9357 we introduce the Db level
lock as well. With that I think its cleaner to have {{Lockable}} interface
which both the Db and Table implements. The interface will provide methods such
as {{lock}}, {{unlock}} and {{tryLock}}. We have multiple places in the code
where we do Table.getLock().lock(). Ideally, lock object of the table should be
private and we should not have a public method to give access to the lock.
Instead having {{table.lock(), table.unlock()}} and {{table.tryLock()}} is
cleaner. Creating this JIRA to track this code change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]