[
https://issues.apache.org/jira/browse/IMPALA-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053293#comment-17053293
]
ASF subversion and git services commented on IMPALA-4080:
---------------------------------------------------------
Commit 92839b7e835229ce889f1777cd3be032c0842c9f in impala's branch
refs/heads/master from Bikramjeet Vig
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=92839b7 ]
IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a
Config object
This introduces a new class called TupleRowComparatorConfig that houses
the fragment level parameters needed to create a TupleRowComparator
object. It also codegens the TupleRowComparator::Compare() method that
is shared by all instances of TupleRowComparator objects created using
this config. Also, moved the related code to initiate codegen on this
class for the exchange, sort, partial sort and top-n nodes from their
exec nodes to their plan nodes.
Lastly, this also moved the code responsible for codegening
TopNNode::InsertBatch() from its exec node to its plan node.
Testing:
TODO: Sucessfully run exhaustive tests. Need to re-run after resolving
rebase conflicts.
Manually verified that codegen works for all modified exec nodes.
Change-Id: I265604ecbae2c80ff59e697fddfeea4976b25cd9
Reviewed-on: http://gerrit.cloudera.org:8080/15281
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Share codegen work between fragment instances
> ---------------------------------------------
>
> Key: IMPALA-4080
> URL: https://issues.apache.org/jira/browse/IMPALA-4080
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 2.8.0
> Reporter: Tim Armstrong
> Assignee: Bikramjeet Vig
> Priority: Major
> Labels: codegen, multithreading
>
> With multithreading, we should find a way to share codegen modules between
> fragment instances to avoid redundant compilation, optimisation, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
