[
https://issues.apache.org/jira/browse/IMPALA-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Tauber-Marshall resolved IMPALA-9414.
--------------------------------------------
Resolution: Fixed
commit 3fd6f60b2219d31d61bd838e94a7f8f9df3d15e2
Author: Thomas Tauber-Marshall <[email protected]>
Date: Fri Feb 21 14:37:35 2020 -0800
IMPALA-9414 (part 2): Support the 'Expect: 100-continue' http header
The 'Expect: 100-continue' http header allows http clients to send
only the headers for their request, get a confirmation back from the
server that the headers are valid, and only then send the body of the
request, avoiding the overhead of sending large requests that will
ultimately fail.
This patch adds support for this in the HS2 HTTP server by having
THttpServer look for the header, and if it's present and the request
is validated returning a '100 Continue' response before reading the
body of the request.
It also adds supports for using this header on large requests sent by
impala-shell.
Testing:
- This case is covered by the existing test_large_sql, however that
test was previously broken and passing spuriously. This patch fixes
the test.
- Passed all other shell tests.
Change-Id: I4153968551acd58b25c7923c2ebf75ee29a7e76b
Reviewed-on: http://gerrit.cloudera.org:8080/15284
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Thomas Tauber-Marshall <[email protected]>
commit c3d65cab55789b3cc6950eec072b9931db57e4fe
Author: Thomas Tauber-Marshall <[email protected]>
Date: Fri Feb 21 15:29:58 2020 -0800
IMPALA-9414 (part 1): Copy THttpClient from Thrift into Impala
This is a prelimary patch that simply copies THttpClient.py from
Thrift master into Impala, changes imports as appropriate, and adjusts
the formatting from 4 spaces to 2 spaces.
This is to allow us to make modifications to THttpClient in future
patches. There are no functional changes in this patch.
Change-Id: I2662f1d4d455120442ef7c0c198685c07207aeed
Reviewed-on: http://gerrit.cloudera.org:8080/15283
Reviewed-by: Tim Armstrong <[email protected]>
Reviewed-by: David Knupp <[email protected]>
Tested-by: Thomas Tauber-Marshall <[email protected]>
> Support the Expect: 100-continue http header
> --------------------------------------------
>
> Key: IMPALA-9414
> URL: https://issues.apache.org/jira/browse/IMPALA-9414
> Project: IMPALA
> Issue Type: Improvement
> Components: Clients
> Affects Versions: Impala 3.4.0
> Reporter: Thomas Tauber-Marshall
> Assignee: Thomas Tauber-Marshall
> Priority: Major
>
> The "Expect: 100-continue" http header allows http clients to send only the
> headers for their request, get a confirmation back from the server that the
> headers are valid, and only then send the body of the request, avoiding the
> overhead of sending large requests that will ultimately fail.
> This would be useful for Impala in situations like submitting a large query
> to a Kerberos-secured Impala where requests are proxied through Apache Knox,
> where it would allow us to verify the credentials before the query text is
> send over the network.
> We should implement support for this both in the hs2 http server and in any
> clients.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
